Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yichen1 ai 5172 refactor hd matching #61

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ycbiometrics
Copy link
Contributor

{{yichen1-ai-5172-refactor-hd-matching}}

PR description

refactor matching functions, including

  1. change sqrt term to linear approximation in normalization
  2. add option of separate_half_matching to HammingDistanceMatcher so it can be computed with or without separating iris to upper and lower halves.
  3. remove option of nm_type, only keep linear fusion when separate_half_matching is enabled.
  4. refactor utils.py and reduce lines of code by 60

Issue

Solution

Limitations

Type

  • Feature
  • Refactoring
  • Bugfix
  • DevOps
  • Testing

Checklist

  • I've made sure that my code works as expected by writing unit tests.
  • I've checked if my code doesn't generate warnings or errors.
  • I've performed a self-review of my code.
  • I've made sure that my code follows the style guidelines of the project.
  • I've commented hard-to-understand parts of my code.
  • I've made appropriate changes in the documentation.

@ycbiometrics ycbiometrics requested a review from a team as a code owner January 23, 2025 20:01
@ycbiometrics ycbiometrics changed the base branch from main to dev January 23, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants